Revert changes to buildPackages for nix-tools #134
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Nix when cross-compiling
This is something we should fix in haskell.nix properly, I think. I'll look into this. |
|
I'll close this, as it's starting to bit rot and I still think we should fix this properly in haskell.nix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes made before merging #116 broke the use of callStackToNix in a cross-compiled package set. This reverts those changes. Before the changes, callStackToNix would use nix-tools and nix-prefetch-git from the build platform, after the changes, it attempts to build them on the cross-compilation target, and then run them on the build platform.
Simply calling the nix-tools derivation from pkgs.buildPackages is not sufficient, seemingly due to the way haskell.nix propagates the package set and stdenv. I was not able to track down exactly why, but it seems necessary to make a buildPackages scope that can be used to call callStackToNix and/or nix-tools.
This PR reverts that set of changes, so that callStackToNix will work properly on cross-compiled builds.