Fail when haddock fails by default #359
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't run haddock when there are no source files
angerman
reviewed
Dec 10, 2019
|
@angerman can you give me an example of that? I'd like to think it should work (I added a check), but I haven't tested. |
|
It's one of the compat packages on hackage I believe. I'll try to find it. |
|
I don't think it was this one: http://hackage.haskell.org/package/mtl-compat |
|
@angerman Thanks, I will look at it. I guess the only way to fix this would be to parse the output of haddock and look at what errors were produced. |
|
@angerman it builds with those flags on this branch. |
angerman
approved these changes
Dec 13, 2019
hamishmack
added a commit
that referenced
this pull request
Dec 18, 2019
hamishmack
added a commit
that referenced
this pull request
Dec 19, 2019
hamishmack
added a commit
that referenced
this pull request
Dec 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't run haddock when there are no source files. Otherwise, if haddock fails, the build will fail as well.