Skip to content

Automatically generate cache for stackage projects #397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 16 commits into from
Jan 14, 2020
Merged

Automatically generate cache for stackage projects #397

merged 16 commits into from
Jan 14, 2020

Conversation

hamishmack
Copy link
Collaborator

This is an updated version of #358 that uses input-output-hk/nix-tools#72 for parsing stack.yaml and extracting the cabal package name. It also supports adding the nix hash as a comment to stack.yaml (this should make passing a manual cache argument unnecessary).

balsoft and others added 13 commits December 30, 2019 14:28
@balsoft
Automatically generate cache
a5a6700
@balsoft
fixup! Automatically generate cache
060c917 
Print out the cache so that users can speed up builds
@balsoft
fixup! Automatically generate cache
668ed0d 
Mark all non-https repos as private
@balsoft
fixup! fixup! Automatically generate cache
1f00735 
Don't pass sha256 to private fetches
@balsoft
fixup! Automatically generate cache
672194c 
Fix logic error
@balsoft
fixup! Automatically generate cache
e39638b 
Import stack-to-nix as a subtree
@balsoft
fixup! fixup! Automatically generate cache
e6cfdd8
@balsoft
fixup! fixup! Automatically generate cache
5814815
@hamishmack
Merge remote-tracking branch 'origin/master' into balsoft/auto-genera…
104a347 
…te-cache
@hamishmack
nix-tools to parse stack.yaml
23f12ed 
Also adds support for include `# nix-sha256` comments in stack.yaml
files.
@hamishmack
Fix cache generation with local resolver file
52d4bbe
@hamishmack
Use latest nix-tools master branch
6a3402d
@hamishmack
Use origSrcSubDir to access stack.yaml
b978053
@yorickvP
Copy link
Contributor

Does this require the nix-hash comment?

@hamishmack
Copy link
Collaborator Author

Does this require the nix-hash comment?

No the # nix-sha256: comment should only be needed if we want
the stackProject to work in nix restricted mode and we can still pass
a cache argument to stackProject instead if we prefer.

If the # nix-sha256: comment is not present and no cache argument is
passed this PR should behave the same as #358 did (except it will not
output a trace message suggesting a cache argument).

@hamishmack hamishmack requested a review from angerman January 14, 2020 02:19
angerman
angerman approved these changes Jan 14, 2020
View reviewed changes
Copy link
Collaborator

@angerman angerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. I'd like @yorickvP's input on this as well before we merge this.

yorickvP
yorickvP approved these changes Jan 14, 2020
View reviewed changes
Copy link
Contributor

@yorickvP yorickvP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@yorickvP yorickvP mentioned this pull request Jan 14, 2020
Merged
7 tasks
@hamishmack hamishmack merged commit 8e52ad6 into master Jan 14, 2020
@hamishmack hamishmack deleted the hkm/auto-generate-cache branch January 14, 2020 21:34
fiadliel added a commit to EarnestResearch/er-nix that referenced this pull request Jan 15, 2020
@fiadliel
Update haskell.nix pin
69186da 
This pulls in input-output-hk/haskell.nix#397
(automatically generate cache for stackage projects).
@fiadliel fiadliel mentioned this pull request Jan 15, 2020
Merged
@angerman angerman mentioned this pull request Jan 16, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@angerman angerman angerman approved these changes

@yorickvP yorickvP yorickvP approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hamishmack @yorickvP @angerman @balsoft