Skip to content

stackProject': Expose pkg-set #531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

roberth
Copy link
Contributor

@roberth roberth commented Apr 2, 2020

This will allow the caller to use the haskell.nix options as a submodule.

It's the missing link that will let me make good use of #309 in projects structured with the module system (proof of concept "project.nix", needs docs). Without it, I can't make the config module parameter match the config definitions. Closes #309

@hamishmack
Copy link
Collaborator

Should we add this to cabalProject' too?

@angerman
Copy link
Collaborator

angerman commented Apr 9, 2020

@roberth can you add this (as @hamishmack suggested) to cabalProject' as well? I'm happy to merge this; I'd just prefer not to have this become stack/cabal only features for no good reason.

@roberth roberth force-pushed the stackProjectPrime-expose-pkg-set branch from 39ddeca to e347b3c Compare April 9, 2020 18:44
This will allow the caller to use the haskell.nix options somewhat
like a submodule.
@roberth roberth force-pushed the stackProjectPrime-expose-pkg-set branch from e347b3c to ccbc76d Compare April 9, 2020 18:45
@roberth
Copy link
Contributor Author

roberth commented Apr 9, 2020

@angerman I agree. Done.

@angerman
Copy link
Collaborator

Bors try

iohk-bors bot added a commit that referenced this pull request Apr 10, 2020
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Apr 10, 2020

@hamishmack hamishmack merged commit 57b1cf0 into input-output-hk:master Apr 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

stackProject: builtins.fetchGit to avoid manual sha256s and allow private repos
3 participants