Skip to content

ci(workflows): adopt short commit hash for service version #210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 26, 2025

Conversation

pinglin
Copy link
Member

@pinglin pinglin commented Jun 25, 2025

Because

  • github.sha is the complete commit SHA hash which is too long. Shot commit hash is preferred, especially for the backend service log presentation.

This commit

  • adopted short git commit hash for representing the latest build version

@pinglin pinglin force-pushed the pinglin/ci-fix-service-version branch 7 times, most recently from c62b3a9 to 7c3b6d1 Compare June 26, 2025 16:12
Copy link

codecov bot commented Jun 26, 2025

Codecov Report

Attention: Patch coverage is 0% with 15 lines in your changes missing coverage. Please review.

Project coverage is 0.63%. Comparing base (278c470) to head (7c3b6d1).
Report is 53 commits behind head on main.

Files with missing lines Patch % Lines
pkg/usage/usage.go 0.00% 13 Missing ⚠️
cmd/main/main.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##            main    #210      +/-   ##
========================================
- Coverage   4.56%   0.63%   -3.93%     
========================================
  Files         64      63       -1     
  Lines      22543   22839     +296     
========================================
- Hits        1028     144     -884     
- Misses     21351   22690    +1339     
+ Partials     164       5     -159     
Flag Coverage Δ
unittests 0.63% <0.00%> (-3.93%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@pinglin pinglin force-pushed the pinglin/ci-fix-service-version branch from 7c3b6d1 to 33bf2b4 Compare June 26, 2025 16:30
@pinglin pinglin force-pushed the pinglin/ci-fix-service-version branch from 33bf2b4 to d92787f Compare June 26, 2025 16:48
@pinglin pinglin merged commit 44f0b1b into main Jun 26, 2025
8 checks passed
@pinglin pinglin deleted the pinglin/ci-fix-service-version branch June 26, 2025 16:50
pinglin added a commit that referenced this pull request Jun 28, 2025
Because

- `github.sha` is the complete commit SHA hash which is too long. Shot
commit hash is preferred, especially for the backend service log
presentation.

This commit

- adopted short git commit hash for representing the `latest` build
version
pinglin added a commit that referenced this pull request Jun 28, 2025
Because

- `github.sha` is the complete commit SHA hash which is too long. Shot
commit hash is preferred, especially for the backend service log
presentation.

This commit

- adopted short git commit hash for representing the `latest` build
version
pinglin added a commit that referenced this pull request Jun 28, 2025
Because

- `github.sha` is the complete commit SHA hash which is too long. Shot
commit hash is preferred, especially for the backend service log
presentation.

This commit

- adopted short git commit hash for representing the `latest` build
version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant