Use deferred imports instead of lazy loading #121
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR instructlab#116 added lazy loading of `run_training` function with a PEP 562 `__getattr__` module hook. Pylint does not understand the trick, which caused some problems. Replace the lazy hook with a wrapper function and deferred imports. Also mark all public APIs with a comment, so developers are aware which classes are used by other packages. Signed-off-by: Christian Heimes <[email protected]>
nathan-weinberg
approved these changes
Jul 2, 2024
Atharva1763
pushed a commit
to Atharva1763/training
that referenced
this pull request
Jul 11, 2024
The `main_ds` module imports DeepSpeed and PyTorch. These imports take a very long time and slow down startup of the Instruct CLI `ilab` tool by over a second. Use PEP 562 hooks to implement lazy import and loading for `run_training` function. The function is imported when the attribute is accessed. See: instructlab/instructlab#1467 Signed-off-by: Christian Heimes <[email protected]> Catch Error if Packing Max Batch Len Cannot be Found (instructlab#114) this will remove the control for sampler instead sampler will be decided if the max batch len cannot be found. --------- Signed-off-by: Yu Chin Fabian Lim <[email protected]> Signed-off-by: Mustafa Eyceoz <[email protected]> Co-authored-by: Mustafa Eyceoz <[email protected]> Use deferred imports instead of lazy loading (instructlab#121) PR instructlab#116 added lazy loading of `run_training` function with a PEP 562 `__getattr__` module hook. Pylint does not understand the trick, which caused some problems. Replace the lazy hook with a wrapper function and deferred imports. Also mark all public APIs with a comment, so developers are aware which classes are used by other packages. Signed-off-by: Christian Heimes <[email protected]> Reduce unecessary multiprocessing (instructlab#79) Signed-off-by: Mustafa Eyceoz <[email protected]> Flash Attention Disable Toggle (Take 2) (instructlab#118) For hardware scenarios where flash attention is potentially not supported. For issue instructlab#92 --------- Signed-off-by: Mustafa Eyceoz <[email protected]> 🐛: fix optimizer selection logic so that FusedAdam is never loaded when CPU offloading is enabled (instructlab#122) Signed-off-by: Oleg S <[email protected]> Add wheel to requirements (instructlab#123) Signed-off-by: Mustafa Eyceoz <[email protected]> Revert "Add wheel to requirements (instructlab#123)" This reverts commit b91273e. Changing the script for validation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #116 added lazy loading of
run_trainingfunction with a PEP 562__getattr__module hook. Pylint does not understand the trick, which caused some problems. Replace the lazy hook with a wrapper function and deferred imports.Also mark all public APIs with a comment, so developers are aware which classes are used by other packages.