Skip to content

fixes unit ec2-name #409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 24, 2025
Merged

fixes unit ec2-name #409

merged 2 commits into from
Jan 24, 2025

Conversation

@JamesKunstle
Copy link
Contributor

@JamesKunstle JamesKunstle commented Jan 23, 2025

Recreating the PR from a branch that has access to repo environment variables + secrets.

@JamesKunstle JamesKunstle self-assigned this Jan 23, 2025
@mergify mergify bot added the CI/CD Affects CI/CD configuration label Jan 23, 2025
This was referenced Jan 23, 2025
Closed
Closed
@mergify mergify bot added the ci-failure label Jan 23, 2025
@mergify mergify bot added ci-failure and removed ci-failure labels Jan 23, 2025
danmcp
danmcp reviewed Jan 23, 2025
View reviewed changes
@mergify mergify bot added ci-failure and removed ci-failure labels Jan 23, 2025
@mergify mergify bot removed the ci-failure label Jan 23, 2025
danmcp
danmcp reviewed Jan 23, 2025
View reviewed changes
@JamesKunstle
Copy link
Contributor Author

JamesKunstle commented Jan 23, 2025

@courtneypacheco I learned from your PR here to get this test to pass. Thanks for identifying the changes that needed to be made! I'd like to merge this PR when I've changed the instance type and removed the nvidia-smi call. Would that be okay with you? I think that would close your PR w/ you further work required on your end.

@danmcp
Copy link
Member

danmcp commented Jan 23, 2025

@courtneypacheco I learned from your PR here to get this test to pass. Thanks for identifying the changes that needed to be made! I'd like to merge this PR when I've changed the instance type and removed the nvidia-smi call. Would that be okay with you? I think that would close your PR w/ you further work required on your end.

@JamesKunstle You should add @courtneypacheco as a Co-author on your commit

@JamesKunstle
Copy link
Contributor Author

JamesKunstle commented Jan 23, 2025

@courtneypacheco I learned from your PR here to get this test to pass. Thanks for identifying the changes that needed to be made! I'd like to merge this PR when I've changed the instance type and removed the nvidia-smi call. Would that be okay with you? I think that would close your PR w/ you further work required on your end.

@JamesKunstle You should add @courtneypacheco as a Co-author on your commit

Definitely- just updated.

@JamesKunstle @courtneypacheco
fix unit-testing workflow file
240ddf9 
workflow file had wrong name and step return value. this amends that so
that the workflow can run.

Co-authored-by: James Kunstle <[email protected]>
Co-authored-by: Courtney Pacheco <[email protected]>
Signed-off-by: James Kunstle <[email protected]>
@JamesKunstle JamesKunstle requested a review from danmcp January 24, 2025 21:12
@mergify mergify bot added the one-approval label Jan 24, 2025
@JamesKunstle JamesKunstle merged commit e1ef2ee into main Jan 24, 2025
9 checks passed
@JamesKunstle JamesKunstle deleted the fix-unit-ec2-name branch January 24, 2025 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@courtneypacheco courtneypacheco Awaiting requested review from courtneypacheco

1 more reviewer

@danmcp danmcp danmcp approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@JamesKunstle JamesKunstle

Labels

CI/CD Affects CI/CD configuration one-approval

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@JamesKunstle @danmcp