Skip to content

Conversation

@JamesKunstle
Copy link
Contributor

Liger Kernels from Linkedin Research are a drop-in performance optimization that improves training throughput by ~35% in the best case. This PR adds the option to enable the kernels for supported model architectures and should be a "free" optimization in most cases.

@JamesKunstle JamesKunstle requested a review from RobotSail April 5, 2025 22:12
@JamesKunstle JamesKunstle self-assigned this Apr 5, 2025
@mergify mergify bot added ci-failure dependencies Pull requests that update a dependency file labels Apr 5, 2025
Copy link
Member

@RobotSail RobotSail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify mergify bot added the one-approval label Apr 5, 2025
@RobotSail
Copy link
Member

FYI the e2e failure is expected and unrelated to this PR. It is planned to be resolved but currently pending this PR to be merged: instructlab/instructlab#3254

@RobotSail RobotSail force-pushed the backup/jkunstle/granite-liger-kernel branch from ab110bb to 679c831 Compare April 6, 2025 05:32
@JamesKunstle JamesKunstle force-pushed the backup/jkunstle/granite-liger-kernel branch from 296ec30 to 04bcdde Compare April 8, 2025 01:51
@mergify mergify bot added ci-failure and removed ci-failure labels Apr 8, 2025
Signed-off-by: James Kunstle <[email protected]>
@JamesKunstle JamesKunstle force-pushed the backup/jkunstle/granite-liger-kernel branch from 04bcdde to ade0634 Compare April 8, 2025 04:26
@mergify mergify bot removed the ci-failure label Apr 8, 2025
@JamesKunstle JamesKunstle requested a review from cdoern April 8, 2025 04:32
@mergify mergify bot added the ci-failure label Apr 8, 2025
@mergify mergify bot removed the one-approval label Apr 8, 2025
@RobotSail RobotSail merged commit bc6d480 into main Apr 8, 2025
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-failure dependencies Pull requests that update a dependency file jira

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants