chore: don't trigger unit tests for cuda and rocm requirements changes #463
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
This pull request has merge conflicts that must be resolved before it can be |
Signed-off-by: Ihar Hrachyshka <[email protected]>
booxter
force-pushed
the
specialize-filter-path-for-requirement
branch
from
b3b64d7 to
0097b07
Compare
RobotSail
reviewed
Apr 16, 2025
Member
RobotSail
left a comment
RobotSail
left a comment
There was a problem hiding this comment.
I think I'm missing some context here but why would we want to do this? What if there's a package being installed through one of those libraries for some reason and the change creates bugs elsewhere?
Contributor
Author
|
@RobotSail only requirements.txt and -dev.txt are used for unit tests: https://github.com/instructlab/training/blob/2519deaf4e1a69925d3d42b43e62f7fb4994dab4/tox.ini#L25C8-L25C28 |
JamesKunstle
approved these changes
Apr 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ihar Hrachyshka [email protected]