-
Notifications
You must be signed in to change notification settings - Fork 74
chore: Drop pytest-asyncio #467
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Drop pytest-asyncio #467
Conversation
|
Why do we need the asyncio stuff in this lib anyway? I've been wondering if we can just drop that requirement altogether |
|
We can definitely drop it at least until we feel the need. I will drop. |
e655eb2 to
1d7ae1c
Compare
Signed-off-by: Ihar Hrachyshka <[email protected]>
|
This pull request has merge conflicts that must be resolved before it can be |
1d7ae1c to
48a5791
Compare
|
@JamesKunstle We use async logic in order to optimize I/O logic and optimize the amount of CPU time available so the training loop doesn't hang on blocking FS write calls. You can see this in action if you look at the AsyncStructuredLogger implementation here: https://github.com/instructlab/training/blob/main/src/instructlab/training/async_logger.py |
RobotSail
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can remove this now, but I have a feeling we will need to just bring it back in again later.
JamesKunstle
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can re-add this when we have tests that need it. For now it's tidier to just remove it.
No description provided.