deps: Remove caps on ROCm dependencies #517
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't need to cap these dependencies at this time. Signed-off-by: Courtney Pacheco <[email protected]>
booxter
approved these changes
May 1, 2025
Contributor
|
Are we running this through e2e? |
Contributor
Author
|
@ktdreyer We don't have any E2E tests that validate training against AMD ROCm accelerators. |
Contributor
|
There are no tests for ROCm upstream. We don't have hardware (atm). |
cdoern
approved these changes
May 1, 2025
Contributor
Author
|
@mergify backport release-v0.10 |
Contributor
✅ Backports have been created
|
mergify bot
added a commit
that referenced
this pull request
May 1, 2025
deps: Remove caps on ROCm dependencies (backport #517)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
We don't need to cap these dependencies at this time. If we do, we should cap them in a
constraints-dev.txtfile like we do in the core repo, but we don't actually need a constraints file if we're not testing upstream.