ci: don't trigger pull_request_target job on its own workflow #519
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pull_request_target means that the workflow will be pulled from main, not from the PR under review; so it's a waste to run the workflow in this case. Signed-off-by: Ihar Hrachyshka <[email protected]>
ktdreyer
reviewed
May 1, 2025
Contributor
ktdreyer
left a comment
ktdreyer
left a comment
There was a problem hiding this comment.
The reasoning sounds right to me.
danmcp
approved these changes
May 1, 2025
ktdreyer
approved these changes
May 1, 2025
mergify
bot
deleted the
ihrachyshka-dont-trigger-on-own-workflow-for-pull-request-targets
branch
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pull_request_target means that the workflow will be pulled from main,
not from the PR under review; so it's a waste to run the workflow in
this case.
Signed-off-by: Ihar Hrachyshka [email protected]