remove old Deepspeed-native code #567
Conversation
|
running CI to spot-check that removed code didn't break training. I checked for references to code being used but didn't find any with vscode, but maybe missed something. |
JamesKunstle
force-pushed
the
remove-dead-code
branch
from
dc2d89b to
750babb
Compare
RobotSail
left a comment
RobotSail
left a comment
There was a problem hiding this comment.
Looks good, if we can get CI passing then I can approve ✅
JamesKunstle
force-pushed
the
remove-dead-code
branch
from
750babb to
2ef7a32
Compare
RobotSail
left a comment
RobotSail
left a comment
There was a problem hiding this comment.
Looks like everything but the smoke tests pass, I believe the smoke tests are flaky anyways however.
|
Re-running the tests. I think @booxter fixed the GitHub Action dependency that was causing these to break last time. |
JamesKunstle
force-pushed
the
remove-dead-code
branch
from
2ef7a32 to
8d22c7f
Compare
|
@JamesKunstle unless you really need the other two reviews, consider removing them from the requests so that this PR can merge. |
|
This pull request has merge conflicts that must be resolved before it can be |
JamesKunstle
force-pushed
the
remove-dead-code
branch
from
8d22c7f to
ad0ed22
Compare
|
Rebased, no other changes |
after moving to Accelerate, we left some old code in-tree in case we had to switch back. We can remove it now that we've settled on Accelerate. Signed-off-by: James Kunstle <[email protected]>
JamesKunstle
force-pushed
the
remove-dead-code
branch
from
ad0ed22 to
fdc02fd
Compare
3 participants
after moving to Accelerate, we left some old code in-tree in case we had to switch back. We can remove it now that we've settled on Accelerate.