Skip to content

ci: Cover more test dependencies with pins #581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 4, 2025
Merged

ci: Cover more test dependencies with pins #581

merged 1 commit into from
Jun 4, 2025

Conversation

@booxter
Copy link
Contributor

@booxter booxter commented May 30, 2025 •
edited
Loading

Closes: #575

@mergify mergify bot added CI/CD Affects CI/CD configuration testing Relates to testing dependencies Pull requests that update a dependency file ci-failure labels May 30, 2025
@booxter booxter force-pushed the more-constraints branch from baceeee to e020dd3 Compare May 30, 2025 17:39
@mergify mergify bot removed the ci-failure label May 30, 2025
@booxter booxter added the hold label May 30, 2025
@mergify
Copy link
Contributor

mergify bot commented May 31, 2025

This pull request has merge conflicts that must be resolved before it can be
merged. @booxter please rebase it. https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@mergify mergify bot added the needs-rebase label May 31, 2025
@booxter booxter force-pushed the more-constraints branch from e020dd3 to 89b405c Compare May 31, 2025 18:32
@mergify mergify bot removed the needs-rebase label May 31, 2025
@github-actions
Copy link

github-actions bot commented May 31, 2025

E2E (NVIDIA L40S x4) workflow launched on this PR: View run

@github-actions
Copy link

github-actions bot commented May 31, 2025

e2e workflow succeeded on this PR: View run, congrats!

@booxter booxter removed the hold label Jun 2, 2025
@mergify mergify bot added the one-approval label Jun 3, 2025
@booxter booxter requested a review from a team June 4, 2025 13:38
@mergify mergify bot merged commit 7df93dc into instructlab:main Jun 4, 2025
18 checks passed
@mergify mergify bot removed the one-approval label Jun 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cdoern cdoern cdoern approved these changes

+1 more reviewer

@JamesKunstle JamesKunstle JamesKunstle approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

CI/CD Affects CI/CD configuration dependencies Pull requests that update a dependency file testing Relates to testing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Capture more test dependencies in constraints

3 participants

@booxter @cdoern @JamesKunstle