Removes Numpy version cap #664
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ly uncaps numpy Signed-off-by: Oleg Silkin <[email protected]>
Maxusmusti
reviewed
Oct 13, 2025
requirements.txt
Outdated
| datasets>=2.15.0 | ||
| numba | ||
| numpy>=1.26.4,<2.3 | ||
| numba>= 0.62.0 |
Collaborator
There was a problem hiding this comment.
Can you remove the extra space?
Signed-off-by: Oleg Silkin <[email protected]>
Maxusmusti
approved these changes
Oct 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the numpy max version cap, since numba currently supports all available numpy versions.
Previously, numba had capped versions of numpy to be below 2.3, which resulted in the current cap.
However, numba doesn't limit the max possible version for numpy, which can be seen in their
setup.pyfile:https://github.com/numba/numba/blob/338b0a2a98a3ede6fba7888a03726804d2059a61/setup.py#L373
To align with this change and make it easier for our library to be consumed, this PR removes the max version cap on numpy.