Skip to content

Conversation

mgrover1
Copy link
Collaborator

@mgrover1 mgrover1 commented Jun 1, 2022

Change Summary

This adds the ability to read kerchunk reference files

Related issue number

Checklist

  • Unit tests for the changes exist
  • Tests pass on CI
  • Documentation reflects the changes where applicable

@mgrover1 mgrover1 requested a review from andersy005 as a code owner June 1, 2022 02:28
@andersy005
Copy link
Member

andersy005 commented Jun 4, 2022

This looks great, @mgrover1! When you get a chance, do you mind updating the specification: https://github.com/intake/intake-esm/blob/main/docs/source/explanation/esm-catalog-spec.md#assets-object to reflect this new addition?

@mgrover1
Copy link
Collaborator Author

mgrover1 commented Jun 4, 2022

@andersy005 thanks! I updated the spec to reflect the change!

Copy link
Member

@andersy005 andersy005 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome 👏🏽!! Merging this shortly. In case we missed something we shall address it in a follow up PR

@andersy005 andersy005 merged commit ff8a2c5 into intake:main Jun 4, 2022
@mgrover1 mgrover1 deleted the add-kerchunk branch June 4, 2022 04:47
@andersy005 andersy005 added the enhancement Issues that are found to be a reasonable candidate feature additions label Aug 18, 2022
@aulemahal aulemahal mentioned this pull request Nov 7, 2022
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Issues that are found to be a reasonable candidate feature additions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support datasets that use ReferenceFileSystem (fsspec-reference-maker)
2 participants