Skip to content

Conversation

aulemahal
Copy link
Contributor

@aulemahal aulemahal commented Oct 19, 2022

Change Summary

Cast paths to string before passing to fsspec.

Related issue number

Fixes #540.

Checklist

  • Unit tests for the changes exist
  • Tests pass on CI
  • Documentation reflects the changes where applicable

Cast paths to string before passing to fsspec.
@aulemahal aulemahal requested a review from andersy005 as a code owner October 19, 2022 16:07
Copy link
Member

@andersy005 andersy005 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this fix, @aulemahal!

@andersy005 andersy005 enabled auto-merge (squash) October 19, 2022 17:47
@andersy005 andersy005 added enhancement Issues that are found to be a reasonable candidate feature additions bug-fix labels Nov 16, 2022
@andersy005
Copy link
Member

It appears this PR is also impacted by the netCDF's thread safety issue reported in #548

@mgrover1
Copy link
Collaborator

@andersy005 - can we set the following

Folks using iris and hitting this issue you can workaround it by setting dask to single-threaded with:

import dask
dask.config.set(scheduler="single-threaded")

instead of pinning to netcdf4!=1.6.1.

for now?

@mgrover1
Copy link
Collaborator

mgrover1 commented Nov 16, 2022

That was mentioned in this issue Unidata/netcdf4-python#1192

and in the xarray repo pydata/xarray#7079

@mgrover1
Copy link
Collaborator

It appears this PR is also impacted by the netCDF's thread safety issue reported in #548

This has been fixed using the snippet I mentioned before... should be good for review

@andersy005 andersy005 merged commit c7cc334 into intake:main Nov 16, 2022
@aulemahal aulemahal deleted the patch-1 branch November 16, 2022 20:10
@andersy005
Copy link
Member

thank you, @mgrover1 / @aulemahal

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug-fix enhancement Issues that are found to be a reasonable candidate feature additions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Passing Path objects to esm_datastore
3 participants