Skip to content

Conversation

fnattino
Copy link
Contributor

Fix for #97

@TomAugspurger
Copy link
Collaborator

Thanks, can you add a small test for this?

And if you merge main and repush then the CI failures should be fixed.

@fnattino
Copy link
Contributor Author

Hi @TomAugspurger , sure! I have added a test based on the single-file STAC that was already in the repo, checking whether the media types for all assets are listed in the drivers dictionary. I have also thought it was a good idea to check whether all common media types listed in PySTAC are also listed among the drivers, and realised that image/tiff is actually missing. Should I add it to the dictionary as well (I guess with rasterio as driver)?

@TomAugspurger
Copy link
Collaborator

Thanks, that would be great. Either here or as a followup would be fine.

@TomAugspurger
Copy link
Collaborator

Thanks @fnattino!

@TomAugspurger TomAugspurger merged commit 7d89adc into intake:main Jun 29, 2021
@fnattino fnattino deleted the fix/application-xml branch June 29, 2021 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants