Remove benchmark submodules #217
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Registering the benchmark corpuses as submodules is convenient, but has drawbacks as well. 1. depending on how people clone the repo, they may drag in a bunch of irrelevant stuff 2. it kind of looks like we are 'using' the code from these repos, but we aren't 3. `cargo install --git` will clone all submodules, slowing down an install using this method This change makes the benchmark code clone the repo manually to a gitignored folder. See - rust-lang/cargo#4247
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
jgardn3r
reviewed
Mar 20, 2025
jgardn3r
approved these changes
Mar 21, 2025
zaneduffield
merged commit d47aaa6
into
integrated-application-development:master
7 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Registering the benchmark corpuses as submodules is convenient, but has drawbacks as well.
cargo install --gitwill clone all submodules, slowing down an install using this methodThis change makes the benchmark code clone the repo manually to a gitignored folder.
See