Skip to content

[MAINT] Improve provider tests#3061

Merged
nickfloyd merged 9 commits intointegrations:mainfrom
F-Secure-web:improve-provider-tests
Jan 9, 2026
Merged

[MAINT] Improve provider tests#3061
nickfloyd merged 9 commits intointegrations:mainfrom
F-Secure-web:improve-provider-tests

Conversation

@deiga
Copy link
Collaborator

@deiga deiga commented Jan 7, 2026

Supersedes #3033


Before the change?

  • It was possible to inadvertently set token and app_auth at the same time
  • Some provider test's weren't actually testing anything

After the change?

  • Ensures that token (or GITHUB_TOKEN) and app_auth can't be set at the same time
  • Updated some provider tests to actually initialize the provider and verify changes

Pull request checklist

  • Schema migrations have been created if needed (example)
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes
  • No

deiga added 9 commits January 7, 2026 22:26
Signed-off-by: Timo Sand <timo.sand@f-secure.com>
…the same time

Signed-off-by: Timo Sand <timo.sand@f-secure.com>
Signed-off-by: Timo Sand <timo.sand@f-secure.com>
Signed-off-by: Timo Sand <timo.sand@f-secure.com>
Signed-off-by: Timo Sand <timo.sand@f-secure.com>
Signed-off-by: Timo Sand <timo.sand@f-secure.com>
Signed-off-by: Timo Sand <timo.sand@f-secure.com>
Signed-off-by: Timo Sand <timo.sand@f-secure.com>
Signed-off-by: Timo Sand <timo.sand@f-secure.com>
@github-actions
Copy link

github-actions bot commented Jan 7, 2026

👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labeled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀

Copy link
Collaborator

@stevehipwell stevehipwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. It might be worth adding support for app auth via env variable? This is something we require to better be able to run integration tests.

@stevehipwell stevehipwell added this to the v6.10.0 Release milestone Jan 8, 2026
@stevehipwell stevehipwell added the Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR label Jan 8, 2026
@deiga
Copy link
Collaborator Author

deiga commented Jan 9, 2026

@stevehipwell Yeah, that could be good, but I don't think it's best to do in this PR. There is an open Feature request for that as well

Copy link
Collaborator

@stevehipwell stevehipwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nickfloyd nickfloyd merged commit 1268edb into integrations:main Jan 9, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants