fix: Relax id parsing strictness for existing ids#3129
Merged
stevehipwell merged 1 commit intointegrations:mainfrom Jan 28, 2026
Merged
fix: Relax id parsing strictness for existing ids#3129stevehipwell merged 1 commit intointegrations:mainfrom
stevehipwell merged 1 commit intointegrations:mainfrom
Conversation
|
👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labeled with |
nickfloyd
approved these changes
Jan 28, 2026
deiga
approved these changes
Jan 28, 2026
Signed-off-by: Steve Hipwell <steve.hipwell@gmail.com>
stevehipwell
force-pushed
the
fix-id-parsing-strictness
branch
from
d39f9b9 to
ecee52e
Compare
deiga
pushed a commit
to F-Secure-web/terraform-provider-github
that referenced
this pull request
Jan 29, 2026
Signed-off-by: Steve Hipwell <steve.hipwell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #3105
This fixes a regression in #3079 where this logic for IDs with unescaped
:characters was tightened up due to defects in most resources. Howevergithub_repository_environmentresources would function correctly.Before the change?
:characters in the final part could not be parsedAfter the change?
:characters in the final part can be successfully parsedPull request checklist
Does this introduce a breaking change?
Please see our docs on breaking changes to help!