-
Notifications
You must be signed in to change notification settings - Fork 14
Conversation
README.md
Outdated
make install | ||
```bash | ||
mkdir build && cd build | ||
cmake -DENABLE_CUDA=off .. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Heterogeneous
is a part of our library name but build instructions are for the CPU-only version. Should we propose CUDA enabled build as the default option and describe CPU-only version as an alternative for cases when the CUDA toolkit is not available?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yep, will update CUDA enabled instruction when figure out how to compile it with modin.
README.md
Outdated
|
||
## Test | ||
|
||
Python tests can be run from the python source directory using `pytest`. | ||
|
||
```bash | ||
pytest python/tests/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You mentioned it fails due to the missing Modin dependency. If we are fixing the documentation, then it would be nice to include all the required steps to successfully run tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
c21eeb3
to
da6411c
Compare
Looks like tests are not stable - Build / sanity-test / build (push) Failing after 50m. Also, I would suggest skipping a full rebuild for such minor changes. |
da6411c
to
aa4eff9
Compare
aa4eff9
to
b1cc789
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine, just one comment
README.md
Outdated
``` | ||
|
||
### Issues | ||
|
||
If you meet issues during build refer to [`.github/workflows/build.yml`](https://github.com/intel-ai/hdk/blob/b0bc9ca3f599f648bcc1a8e1eb49c0f02e1f7aca/.github/workflows/build.yml). This file describes compilation steps used for CI build. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think a relative link to the file would be more stable here so that you don't need to update it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, fixed.
b1cc789
to
c5a8e84
Compare
README.md
Outdated
|
||
In `setup_class(..)` body. | ||
|
||
Logs are by default located at `mapd_log/` folder. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kurapov-peter @alexbaden @leshikus Do we have any scripts working with logs or depending on the log dir in some other way? It would be nice to finally rename this dir.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we do except for CI log uploading maybe?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated according to #180
This commit updates build instructions and removes obsolete information. Signed-off-by: Dmitrii Makarenko <[email protected]>
c5a8e84
to
7842966
Compare
This commit updates build instructions and removes obsolete information.
Signed-off-by: Dmitrii Makarenko [email protected]