Skip to content
This repository was archived by the owner on May 9, 2024. It is now read-only.

ResultSet refactoring and clean-up [14/N] #263

Merged
merged 2 commits into from
Mar 13, 2023

Conversation

ienkovich
Copy link
Contributor

This patch moves all code related to ResultSet sorting out of ResultSet class to ResultSetSort.cpp.

@ienkovich ienkovich force-pushed the ienkovich/rs-refactoring-14 branch from f87b581 to 463420a Compare March 7, 2023 08:46
Copy link
Contributor

@kurapov-peter kurapov-peter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, just one comment.


#include <functional>

using Comparator = std::function<bool(const PermutationIdx, const PermutationIdx)>;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The name looks generic and may clash. Do we have any good namespace for it to live in?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately, not. But I can rename it to ResultSetComparatorFn

@ienkovich ienkovich merged commit b3b3c4b into main Mar 13, 2023
@ienkovich ienkovich deleted the ienkovich/rs-refactoring-14 branch March 13, 2023 19:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants