Skip to content
This repository was archived by the owner on May 9, 2024. It is now read-only.

Speed up pytest github actions job #281

Merged
merged 1 commit into from
Mar 14, 2023
Merged

Speed up pytest github actions job #281

merged 1 commit into from
Mar 14, 2023

Conversation

alexbaden
Copy link
Contributor

Tentative fix for the pytest failures.

leshikus
leshikus reviewed Mar 13, 2023
View reviewed changes
Copy link
Contributor

@leshikus leshikus left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest adding the pytest.yml as a subtask to test.yml (after the problem with intermittent failures is fixed), this would also remove extra rebuild

@alexbaden alexbaden force-pushed the alex/fixup_pytest_actions_job branch from dc981d4 to 8827faa Compare March 13, 2023 19:40
@alexbaden alexbaden changed the title Fixup pytest github actions job Speed up pytest github actions job Mar 14, 2023
@alexbaden
Copy link
Contributor Author

Job was fixed here: #273
I dropped that fix from this branch, but I think the changes to use the conda cache are worth keeping. It improves build time from ~45 min to ~25 min.
Making it a subtask is a good idea, but I think we should handle that separately.

@alexbaden alexbaden merged commit 2cbd05c into main Mar 14, 2023
@alexbaden alexbaden deleted the alex/fixup_pytest_actions_job branch March 14, 2023 17:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@leshikus leshikus leshikus left review comments

@ienkovich ienkovich ienkovich approved these changes

@kurapov-peter kurapov-peter Awaiting requested review from kurapov-peter

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexbaden @leshikus @ienkovich