This repository was archived by the owner on May 9, 2024. It is now read-only.
Refactor GPU shared memory tests and add L0-specific ones [1/N] #618
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The failure is similar to what we have previously seen (#116 (comment)). It does reproduce locally with a docker build on a machine that runs the tests successfully in bare-metal mode. The hypothesis is that the driver mismatch causes the flow to use an older version of spirv consumer. Will try to update the driver first (#622). |
… dependencies to be aparent
kurapov-peter
force-pushed
the
pakurapo/smem-tests
branch
from
62dfd0d to
f800e91
Compare
|
The hypothesis proved true, but we'll need yet another driver update as the fix is not yet available in the latest release. It is expected to be published in ~3 weeks. I'm disabling regular runs and will continue with local checks meanwhile. |
ienkovich
approved these changes
Aug 16, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes most of the code for shared memory tests much more generic. Those parts that are platform specific are renamed.
It also adds an analogous test for L0, though not all the cases work now with shared memory. Those that do are enabled.