This repository was archived by the owner on May 9, 2024. It is now read-only.
Assign unique id to Node copy. #619
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ienkovich <[email protected]>
kurapov-peter
approved these changes
Aug 7, 2023
| Node::Node(const Node& other) | ||
| : inputs_(other.inputs_) | ||
| , id_(crt_id_.fetch_add(1)) | ||
| , context_data_(nullptr) |
There was a problem hiding this comment.
So this is basically a shallow copy. Do we need it at all? I.e. would it be reasonable to have the copy constructor do a deep copy?
There was a problem hiding this comment.
This is just a legacy function name. Previously, it was used to deep-copy all expressions referenced by the node. But we switched to immutable expressions, so there is no point to deep-copy them anymore. So, all our deepCopy implementations simply call copy-constructors now.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We assume that all nodes in DAG have unique IDs but
Node::deepCopymethod returns a node with the same ID. Fix it by defining a copy ctor forNode.Resolves #617