Skip to content
This repository was archived by the owner on May 9, 2024. It is now read-only.

Use explicit types in LLVM Loads #655

Merged
merged 8 commits into from
Aug 30, 2023
Merged

Conversation

alexbaden
Copy link
Contributor

In preparation for switching to opaque pointers, remove pointer type accesses from various loads.

@alexbaden
Copy link
Contributor Author

Windows failure is the same old reloc one:

2023-08-29T20:18:12.3501189Z   17: Test command: D:\a\hdk\hdk\build\omniscidb\Tests\Release\NoCatalogSqlTest.exe "--gtest_output=xml:../"
2023-08-29T20:18:12.3502027Z   17: Working Directory: D:/a/hdk/hdk/build/omniscidb/Tests
2023-08-29T20:18:12.3502600Z   17: Test timeout computed to be: 10000000
2023-08-29T20:18:12.5638518Z   17: [==========] Running 7 tests from 2 test suites.
2023-08-29T20:18:12.5639782Z   17: [----------] Global test environment set-up.
2023-08-29T20:18:12.5640615Z   17: [----------] 5 tests from NoCatalogSqlTest
2023-08-29T20:18:12.5863584Z   17: [ RUN      ] NoCatalogSqlTest.SelectSingleColumn
2023-08-29T20:18:16.3293732Z   17: [       OK ] NoCatalogSqlTest.SelectSingleColumn (3708 ms)
2023-08-29T20:18:16.3295300Z   17: [ RUN      ] NoCatalogSqlTest.SelectAllColumns
2023-08-29T20:18:16.3666987Z   17: [       OK ] NoCatalogSqlTest.SelectAllColumns (70 ms)
2023-08-29T20:18:16.3667998Z   17: [ RUN      ] NoCatalogSqlTest.SelectAllColumnsMultiFrag
2023-08-29T20:18:17.3852297Z 17 : LLVM error : IMAGE_REL_AMD64_ADDR32NB relocation requires an ordered section layout [D:\a\hdk\hdk\build\omniscidb\Tests\sanity_tests.vcxproj]
2023-08-29T20:18:17.3853427Z   13/17 Test #17: NoCatalogSqlTest .................***Failed    4.10 sec

and can be ignored.

@alexbaden alexbaden merged commit 2df0515 into main Aug 30, 2023
@alexbaden alexbaden deleted the alex/remove_typed_pointers branch August 30, 2023 01:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants