This repository was archived by the owner on May 9, 2024. It is now read-only.
Replace dictionary proxies with nested dictionaries 07/N #680
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ienkovich <[email protected]>
ienkovich
force-pushed
the
ienkovich/nested-dict-07
branch
from
aa365af to
391008c
Compare
kurapov-peter
approved these changes
Sep 29, 2023
| : string_dict_(sd), generation_(generation) {} | ||
| : string_dict_(sd), generation_(generation) { | ||
| if (generation_ < 0) { | ||
| generation_ = static_cast<int64_t>(sd->storageEntryCount()); |
There was a problem hiding this comment.
Do you plan to forbid negative values later on?
There was a problem hiding this comment.
Yes, it will be in the next patch.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid negative generation in dictionary proxy. There is no strong reason to create a proxy with a negative generation anyway. Non-zero generation on a proxy creation would allow us later to stop using negative indices for transient strings. Non-negative indices would allow deep nesting and let us treat proxy-encoded columns as regular dictionary-encoded columns.