This repository was archived by the owner on May 9, 2024. It is now read-only.
Misc recovery items from LLVM Upgrade #708
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Earlier versions of LLVM do not support opaque pointers. LLVM 15 does not support opaque pointers in SPIRV. LLVM 16 supports opaque pointers across all backends.
With range join removed, this code is dead
With opaque pointers we cannot rely on pointer introspection to sanity check UDF code. If this becomes a problem in the future we will need to register the struct type when we register the UDF and compare that way.
ienkovich
approved these changes
Oct 23, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that the bulk of the LLVM upgrade code is in, here are a few misc cleanup items.