Skip to content

Remove -DIGC_OPTION__ARCHITECTURE_TARGET build option #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dvrogozh opened this issue Nov 29, 2018 · 5 comments
Closed

Remove -DIGC_OPTION__ARCHITECTURE_TARGET build option #32

dvrogozh opened this issue Nov 29, 2018 · 5 comments

Comments

@dvrogozh
Copy link
Contributor

Please, remove -DIGC_OPTION__ARCHITECTURE_TARGET build option. It is useless: cmake provides other ways to detect your architecture target. If you just need to check bitness:

if(CMAKE_SIZEOF_VOID_P EQUAL 8)
    message("architecture: 64-bit")
else()
    message("architecture: 32-bit")
endif()

If you need to check Linux/Windows/etc., review: https://cmake.org/Wiki/CMake_Cross_Compiling

@dvrogozh
Copy link
Contributor Author

@chivakker : FYI

@iwwu
Copy link
Contributor

iwwu commented Dec 4, 2018

Thank you for the suggestion. Work in progress

@iwwu
Copy link
Contributor

iwwu commented Dec 13, 2018

Request completed. Please use latest code or tag 'igc_release_2018-12-12'. README is updated as well.

@iwwu
Copy link
Contributor

iwwu commented Dec 17, 2018

Closing the issue since the fix is already merged.

@iwwu iwwu closed this as completed Dec 17, 2018
@dvrogozh
Copy link
Contributor Author

dvrogozh commented Jan 4, 2019

works for me. thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants