Skip to content

Include IGA in the default build #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dvrogozh opened this issue Nov 29, 2018 · 8 comments
Closed

Include IGA in the default build #36

dvrogozh opened this issue Nov 29, 2018 · 8 comments
Assignees

Comments

@dvrogozh
Copy link
Contributor

Please, include IGA into default build. This is required to build media-driver VP shaders/kernels: https://github.com/intel/media-driver/tree/master/media_driver/agnostic/gen11_icllp/vp/kernel/Source

@iwwu
Copy link
Contributor

iwwu commented Dec 7, 2018

IGC already included IGA library (i.e. iga64.so) in the build. We are looking into including IGA executable (i.e. iga64.exe) as well.

@iwwu iwwu self-assigned this Jan 7, 2019
@dvrogozh
Copy link
Contributor Author

To build IGA manually:

cd visa/iga
mkdir build && cd build
cmake ..
make

VPG-SWE-Github pushed a commit that referenced this issue Jan 15, 2019
#36

Change-Id: Id4359ad92a0b482e94938e570e45b1b9c2306c71
@iwwu
Copy link
Contributor

iwwu commented Jan 15, 2019

iga64 is stored under /usr/local/bin by default
Available in igc_release_2019-01-15

@iwwu iwwu closed this as completed Jan 15, 2019
@dvrogozh
Copy link
Contributor Author

I was building IGC with (on CentOS 7):

scl enable devtoolset-4 llvm-toolset-7 -- cmake -DIGC_OPTION__OUTPUT_DIR=../igc-install/Release -DCMAKE_INSTALL_PREFIX=/home/dvrogozh/git/github/cmc ../igc
make -j8
make install

And I got iga64 installed twice:

-- Install: /home/dvrogozh/git/github/cmc/bin/iga64
-- Install: /home/dvrogozh/git/github/cmc/./iga64

The second one is unexpected. Can this be, please, fixed?

@iwwu
Copy link
Contributor

iwwu commented Jan 16, 2019

Your request regarding this is already addressed in our pending patch. I will update this issue when it's fixed.
Install: /home/dvrogozh/git/github/cmc/./iga64

@dvrogozh
Copy link
Contributor Author

Sounds good. Thank you.

@dvrogozh
Copy link
Contributor Author

@iwwu : I was just rebuilding IGC and I believe the pending patch you were talking about has landed (I am on b9d9c18). Can you, please, confirm and specify commitid where fix presents?

@iwwu
Copy link
Contributor

iwwu commented Jan 26, 2019

It's on 64632fa (tag: igc_release_2019-01-15)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants