Skip to content

keep a copy of khronos headers #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
chivakker opened this issue Nov 29, 2018 · 3 comments
Closed

keep a copy of khronos headers #37

chivakker opened this issue Nov 29, 2018 · 3 comments
Assignees
@iwwu

Comments

@chivakker
Copy link

Can this program/library do something with the headers? Keep a copy of the version supported or add them as a git submodule? This will result on a building experience less complex.
@iwwu
Copy link
Contributor

iwwu commented Dec 3, 2018

A copy of opencl_headers is required by our BiFModule compilation. We'll evaluate the request and keep you updated.

VPG-SWE-Github pushed a commit that referenced this issue Dec 22, 2018
@iwwu @gfxbot
Store a copy of khronos opencl headers
b415e51 
#37

Change-Id: I05cd6f743a2330291824b8b8d1206a5c033d1a2e
@paigeale paigeale closed this as completed Jan 5, 2019
@iwwu
Copy link
Contributor

iwwu commented Jan 9, 2019

I will need to make 1 more change to switch the code using the default copy of opencl_headers. Once the change is made, I will update README.

@iwwu iwwu reopened this Jan 9, 2019
@iwwu iwwu self-assigned this Jan 15, 2019
VPG-SWE-Github pushed a commit that referenced this issue Jan 16, 2019
@iwwu @gfxbot
Update README to remove opencl_headers requirement
9195e1e 
#37

Change-Id: If442762f9872edab058d03732a3d1b49264a683e
@iwwu
Copy link
Contributor

iwwu commented Jan 16, 2019

The user is no longer required to download opencl_headers separately. README is updated.
Available in igc_release_2019-01-15

@iwwu iwwu closed this as completed Jan 16, 2019
VPG-SWE-Github pushed a commit that referenced this issue Nov 4, 2020
@dlei6g @igcbot
Fixed function signature cloning for argument attributes (#37)
ecb3452 
- When legalizing the function signature for IGC call convention, the argument attributes must be cloned over
- ByVal attribute is used for arguments that changed from by-value to by-reference
VPG-SWE-Github pushed a commit that referenced this issue Nov 5, 2020
@dlei6g @igcbot
Fixed function signature cloning for argument attributes (#37)
36221e5 
- When legalizing the function signature for IGC call convention, the argument attributes must be cloned over
- ByVal attribute is used for arguments that changed from by-value to by-reference
@haonanya haonanya mentioned this issue Jan 25, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@iwwu iwwu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@chivakker @paigeale @iwwu