Fix reading/writing of binary data in concat.py #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On some python versions, writing a binary file requires `bytes`, not `str`. Reading the data in binary mode is probably what we want here.
|
Thank you. The change will be committed to our internal branch and ported here after validation. Thank you. |
|
Change has been made to our internal branch. Will update when it becomes available in open source repo. |
VPG-SWE-Github
pushed a commit
that referenced
this pull request
Dec 8, 2018
For Reference #7 Change-Id: Ic3a0801ccd66bb554c2c47fd555e5a45968c560a
|
Change available in the latest repo |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On some python versions, writing a binary file requires
bytes, notstr. Reading the data in binary mode is probably what we want here.