-
Notifications
You must be signed in to change notification settings - Fork 171
Use GNUInstallDirs for install paths #74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thank you Kevron. I will port this change into our closed source system to go through the proper testing. I will provide feedback if anything goes wrong. |
thanks for the patch, I gave it a try.. but I don't see it install libigdfcl anywhere, since it drops the line for fcl_dll |
The patch was slightly modified to remove ".so" naming convention for we were working on another patch to handle that. Patch to handle GNUInstallDirs will go in tonight |
ok, let me know what the .so patch will be and I'll try that |
Looks like I screwed up the rebase. That would explain why I no longer see libigdfcl locally. @paigeale do you want me to submit without the so rename and with the fcl_dll fix? |
.so rename is applied in 3cc1170 . GNUInstallDirs going in today |
Change-Id: I7e194df02bfb86528539b22aa92846e228268fb4
Looks like 0770a37 covers most of this. closing |
it got reverted though, so shouldn't this be reopened now? |
I also think this one needs to be reopened, but I don't have right to do that. Resolving this issue we need to pay attention at #82 (comment). |
double "cif" directory, but otherwise fine.
Otherwise, ship it! |
libdir might have different name than "lib" (ie, lib32, lib64, etc). Use cmake GNU standards by default which operating systems know to change to match their configuration.
This patch also gives each so a version string.