[SYCL][UR] Fix P2P Access Get Info Query #15152
Conversation
Signed-off-by: Raiyan Latif <[email protected]>
raiyanla
force-pushed
the
fix-can-access-peer-query
branch
from
69d4fdc to
7efff39
Compare
|
@intel/llvm-gatekeepers , please merge this change to address the P2P race conditions. |
| Plugin->call(urUsmP2PPeerAccessGetInfoExp, Device, Peer, UrAttr, returnSize, | ||
| &value, nullptr); |
There was a problem hiding this comment.
@raiyanla , can underlying UR adapter return more than sizeof(int) bytes of data here? If so, we'll write beyond value's storage. If not, what was the issue before?
There was a problem hiding this comment.
Underlying Adapter only returns sizeof(int) max. I think the issue was possibly more with querying for both the returnSize and value at same time. I saw it was returning garbage numbers each time until this PR. All the adapters use the same helper in the implementation for this, and I'm guessing it doesn't set value properly if returnSize is being queried for at the same time. I will need to confirm when I have access to an appropriate machine though.
Signed-off-by: Raiyan Latif <[email protected]>
No description provided.