[SYCL][Graph][UR] Propagate graph update list to UR #17019
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EwanC
force-pushed
the
ewan/UR_update_list
branch
from
edd0ae1 to
099e2b3
Compare
EwanC
force-pushed
the
ewan/UR_update_list
branch
from
099e2b3 to
81e25a9
Compare
EwanC
force-pushed
the
ewan/UR_update_list
branch
from
81e25a9 to
0176505
Compare
EwanC
changed the title
EwanC
force-pushed
the
ewan/UR_update_list
branch
from
0176505 to
1fd571d
Compare
Bensuo
reviewed
Feb 19, 2025
EwanC
force-pushed
the
ewan/UR_update_list
branch
from
1fd571d to
fb60d96
Compare
EwanC
commented
Feb 21, 2025
EwanC
force-pushed
the
ewan/UR_update_list
branch
from
fb60d96 to
c8a5fa8
Compare
aelovikov-intel
approved these changes
Feb 24, 2025
Bensuo
approved these changes
Feb 26, 2025
Update the `urCommandBufferUpdateKernelLaunchExp` API for updating commands in a command-buffer to take a list of commands. The current API operates on a single command, this means that the SYCL-Graph `update(std::vector<nodes>)` API needs to serialize the list into N calls to the UR API. Given that both OpenCL `clUpdateMutableCommandsKHR` and Level-Zero `zeCommandListUpdateMutableCommandsExp` can operate on a list of commands, this serialization at the UR layer of the stack introduces extra host API calls. This PR improves the `urCommandBufferUpdateKernelLaunchExp` API so that a list of commands is passed all the way from SYCL to the native backend API. As highlighted in oneapi-src/unified-runtime#2671 this patch requires the handle translation auto generated code to be able to handle a list of structs, which is not currently the case. This is PR includes a API specific temporary workaround in the mako file which will unblock this PR until a more permanent solution is completed. Co-authored-by: Ross Brunton <[email protected]>
EwanC
force-pushed
the
ewan/UR_update_list
branch
from
c8a5fa8 to
8b12f5a
Compare
EwanC
force-pushed
the
ewan/UR_update_list
branch
from
8b12f5a to
203aad7
Compare
aarongreig
approved these changes
Feb 26, 2025
aelovikov-intel
approved these changes
Feb 26, 2025
EwanC
force-pushed
the
ewan/UR_update_list
branch
from
203aad7 to
139b815
Compare
|
@intel/llvm-gatekeepers This is ready to merge, thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the
urCommandBufferUpdateKernelLaunchExpAPI for updating commands in a command-buffer to take a list of commands.The current API operates on a single command, this means that the SYCL-Graph
update(std::vector<nodes>)API needs to serialize the list into N calls to the UR API. Given that both OpenCLclUpdateMutableCommandsKHRand Level-ZerozeCommandListUpdateMutableCommandsExpcan operate on a list of commands, this serialization at the UR layer of the stack introduces extra host API calls.This PR improves the
urCommandBufferUpdateKernelLaunchExpAPI so that a list of commands is passed all the way from SYCL to the native backend API.As highlighted in oneapi-src/unified-runtime#2671 this patch requires the handle translation auto generated code to be able to handle a list of structs, which is not currently the case. This is PR includes a API specific temporary workaround in the mako file which will unblock this PR until a more permanent solution is completed.
Co-authored-by: Ross Brunton [email protected]