Skip to content

[NFCI][SYCL] Make get_group_id to return by reference #17677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

MrSidims
Copy link
Contributor

It will enforce address space to the return value helping to avoid invalid AS cast from local to private for sret argument that would appear after llvm/llvm-project#128166 and the related work.

It will enforce address space to the return value helping to
avoid invalid AS cast from local to private for sret argument
that would appear after llvm/llvm-project#128166
and the related work.

Signed-off-by: Sidorov, Dmitry <[email protected]>
@MrSidims MrSidims requested a review from a team as a code owner March 27, 2025 10:22
@MrSidims MrSidims requested a review from steffenlarsen March 27, 2025 10:22
Copy link
Contributor

@steffenlarsen steffenlarsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sadly, this change is not in line with the SYCL 2020 specification: https://registry.khronos.org/SYCL/specs/sycl-2020/html/sycl-2020.html#group-class

@MrSidims
Copy link
Contributor Author

Sadly, this change is not in line with the SYCL 2020 specification: https://registry.khronos.org/SYCL/specs/sycl-2020/html/sycl-2020.html#group-class

But the tests are passing! :) Dang, that was a good shot...

@MrSidims MrSidims closed this Mar 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants