[NFCI][SYCL] Make get_group_id to return by reference #17677
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It will enforce address space to the return value helping to avoid invalid AS cast from local to private for sret argument that would appear after llvm/llvm-project#128166 and the related work. Signed-off-by: Sidorov, Dmitry <[email protected]>
steffenlarsen
requested changes
Mar 27, 2025
There was a problem hiding this comment.
Sadly, this change is not in line with the SYCL 2020 specification: https://registry.khronos.org/SYCL/specs/sycl-2020/html/sycl-2020.html#group-class
But the tests are passing! :) Dang, that was a good shot... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It will enforce address space to the return value helping to avoid invalid AS cast from local to private for sret argument that would appear after llvm/llvm-project#128166 and the related work.