Skip to content

[SYCL][Doc] Introduce test plan for free function kernels extension #17886

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 26 commits into from
Apr 22, 2025

Conversation

@dyniols dyniols marked this pull request as ready for review April 7, 2025 14:43
@dyniols dyniols requested a review from a team as a code owner April 7, 2025 14:43
@dyniols dyniols requested a review from steffenlarsen April 7, 2025 14:43
@dyniols
Copy link
Contributor Author

dyniols commented Apr 14, 2025

@lbushi25 @steffenlarsen Friendly ping, could you review ?

Copy link
Contributor

@steffenlarsen steffenlarsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Initial pass is mostly syntax, wording, etc.

martygrant pushed a commit that referenced this pull request Apr 16, 2025
…ed diagnostics if kernel violates restrictions (#17954)

This PR adds test for free function kernels extension that checks
emitted diagnostics if kernel violates restrictions specified in spec
for declaration of free function kernel.

https://github.com/intel/llvm/blob/sycl/sycl/doc/extensions/proposed/sycl_ext_oneapi_free_function_kernels.asciidoc#defining-a-free-function-kernel

Test introduced based on test plan:
#17886
Copy link
Contributor

@steffenlarsen steffenlarsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall I think this looks good. Just a few small comments.

@dyniols
Copy link
Contributor Author

dyniols commented Apr 22, 2025

@intel/llvm-gatekeepers Can we merge this PR ?

@aelovikov-intel aelovikov-intel merged commit e707e66 into intel:sycl Apr 22, 2025
3 checks passed
@dyniols
Copy link
Contributor Author

dyniols commented Apr 29, 2025

PR with updates to the test plan #18235

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants