-
Notifications
You must be signed in to change notification settings - Fork 769
[SYCL][Doc] Introduce test plan for free function kernels extension #17886
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SYCL][Doc] Introduce test plan for free function kernels extension #17886
Conversation
@lbushi25 @steffenlarsen Friendly ping, could you review ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Initial pass is mostly syntax, wording, etc.
Co-authored-by: Steffen Larsen <[email protected]>
Co-authored-by: Steffen Larsen <[email protected]>
Co-authored-by: Steffen Larsen <[email protected]>
Co-authored-by: Steffen Larsen <[email protected]>
Co-authored-by: Steffen Larsen <[email protected]>
Co-authored-by: Steffen Larsen <[email protected]>
Co-authored-by: Steffen Larsen <[email protected]>
Co-authored-by: Steffen Larsen <[email protected]>
Co-authored-by: Steffen Larsen <[email protected]>
…ed diagnostics if kernel violates restrictions (#17954) This PR adds test for free function kernels extension that checks emitted diagnostics if kernel violates restrictions specified in spec for declaration of free function kernel. https://github.com/intel/llvm/blob/sycl/sycl/doc/extensions/proposed/sycl_ext_oneapi_free_function_kernels.asciidoc#defining-a-free-function-kernel Test introduced based on test plan: #17886
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall I think this looks good. Just a few small comments.
@intel/llvm-gatekeepers Can we merge this PR ? |
PR with updates to the test plan #18235 |
https://github.com/intel/llvm/blob/sycl/sycl/doc/extensions/proposed/sycl_ext_oneapi_free_function_kernels.asciidoc