[UR][OpenCL] Add missing mapping for CL_INVALID_KERNEL to UR OpenCL adapter and handle CL_INVALID_KERNEL_DEFINITION in urKernelCreate

[martygrant]

Fixes oneapi-src/unified-runtime#2555

Also handles checking for CL_INVALID_KERNEL_DEFINITION inside urKernelCreate.

[martygrant]

Failing test for Basic/sycl_2020_images/host_task_unsampled_image_write.cpp tracked here #18085

[kbenzie]

CL_INVALID_KERNEL_DEFINITION if the function definition for __kernel function given by kernel_name such as the number of arguments, the argument types are not the same for all devices for which the program executable has been built.

• UR_RESULT_ERROR_INVALID_KERNEL_NAME
  • If pKernelName wasn’t found in hProgram.

I don't think this is the correct mapping. We don't have a direct mapping. Claiming this error condition is an invalid kernel name is misleading.

[martygrant]

yeah probably best to add a new enum for this, I'll add it in a new commit

[kbenzie]

Not sure we need that.

We could handle this only in the entry points that might return this, return UR_RESULT_ERROR_ADAPTER_SPECIFIC and set the message to "<entry point name> failing with CL_INVALID_KERNEL_DEFINITION".

I'm reasonably sure the other adapters won't have a use for a new enum.

[martygrant]

updated it to do this now instead

[kbenzie]

This is supposed to be the error code from clCreateKernel

Suggested change

	UR_RESULT_ERROR_ADAPTER_SPECIFIC);
	CLResult);

[martygrant]

I checked other uses of setErrorMessage and they all seem to pass UR_RESULT_ERROR_ADAPTER_SPECIFIC and the function expects a ur_result_t, just to double check that's correct?

Also looks like I removed the definition of setErrorMessage in the OpenCL adapter as there was no usage of it. I'll add it back in with this change.

[kbenzie]

ur_result_t urAdapterGetLastError(
    ur_adapter_handle_t hAdapter,
    const char **ppMessage,
    int32_t *pError);

It's supposed to match pError which has type int32_t.

Since you say all uses of setErrorMessage take a ur_result_t it seems like we need to change all of them. That can be done in another PR, create an issue for it.

[martygrant]

Created #18260 for this