-
Notifications
You must be signed in to change notification settings - Fork 769
[SYCL] tighten known_identity to finite_math macro #18247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: sycl
Are you sure you want to change the base?
[SYCL] tighten known_identity to finite_math macro #18247
Conversation
Signed-off-by: Chris Perkins <[email protected]>
This isn't approved usage for referencing internal bug reports. We are only supposed to do that when we can't share information there, e.g. issues in underlying proprietary layers. Anything concerning SYCL RT or C/C++ FE is public and should be accessible for anybody reading this PR/commit message. |
@aelovikov-intel - I encouraged everyone to use issue #13813 for technical discussions, but some of it was conducted on the JIRAS. This particular PR is pretty simple, I don't have anything to add to the description or the comment. |
Please summarize relevant bits from these internal bug-reports directly in the PR description and remove references to the jiras. |
Signed-off-by: Chris Perkins <[email protected]>
Some time ago we fixed a bug in
sycl::known_identity
where it was incorrectly usingstd::numeric_limits<T>::infinity()
even in cases where::infinity()
should not have been available. At the time, the fix was to simply test for__FAST_MATH__
.That worked, but was not ideal. Now we are tightening this to use the
__FINITE_MATH_ONLY__
macro which is more accurate.see #13813
__FINITE_MATH_ONLY__
will be set when both the-fno-honor-infinities
and-fno-honor-nans
flags are used. It was felt by the FE team that there is no reasonable case where one of the flags would be used without the other and therefore__FINITE_MATH_ONLY__
is sufficient for this problem ( and superior to the__FAST_MATH__
macro we were using before).