[Driver][SYCL] Do not set workaround predefines with /MDd #18252
Conversation
We are currently setting 2 pre-defines which workaound a compilation issue: -D_CONTAINER_DEBUG_LEVEL=0 and -D_ITERATOR_DEBUG_LEVEL=0. We can no longer rely on these macros as _CONTAINER_DEBUG_LEVEL will be going away with a future release of Visual Studio. The issues that this worked around are detailed in our release notes as a known issue: https://github.com/intel/llvm/blob/aa2c876f529f942943afaf9395694fe07a7f6121/sycl/ReleaseNotes.md?plain=1#L2700 Remove these workarounds in preparation for the upcoming MSVS release.
|
Hi Mike, Is there a JIRA for this to get more details? |
|
I found the JIRA |
Right - the behavior is changing with the current preview release 3 and 4 (i.e when those previews become regular releases). Given the timing of the releases, they will be available during the 2025.2 release timeframe, basically breaking users who update their underlying MSVC version. |
mdtoguchi
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
Should these references be updated as well? |
The release notes look to be a running update. With the next iteration, the workaround should be updated to not use the _CONTAINER_DEBUG_LEVEL value when dealing with the upcoming MSVC releases, but I don't know if there is a valid workaround from that point on. @AlexeySachkov, any thoughts of how we can update the release notes in regards to this? |
|
@srividya-sundaram, any other comments here? We can address the doc updates separately, this is on the MFL and needs to get some movement. Thanks! |
Ok, I thought you were waiting for @AlexeySachkov's feedback.
Can you create a github issue or JIRA to track the doc update? |
Will do - thanks for the review! |
|
@intel/llvm-gatekeepers, this is ready for merge, thanks! |
We are currently setting 2 pre-defines which workaound a compilation issue: -D_CONTAINER_DEBUG_LEVEL=0 and -D_ITERATOR_DEBUG_LEVEL=0. We can no longer rely on these macros as _CONTAINER_DEBUG_LEVEL will be going away with a future release of Visual Studio.
The issues that this worked around are detailed in our release notes as a known issue:
llvm/sycl/ReleaseNotes.md
Line 2700 in aa2c876
Remove these workarounds in preparation for the upcoming MSVS release.