Skip to content

DO NOT MERGE: CI testing #18259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 3 commits into
base: sycl
Choose a base branch
from
Draft

DO NOT MERGE: CI testing #18259

wants to merge 3 commits into from

Conversation

RossBrunton
Copy link
Contributor

No description provided.

@RossBrunton
[UR][CUDA] Remove vtable from ur_exp_command_buffer_handle_t_
1cb6d33 
With the handle removal, we will start requiring handle types to not have
vtables. This changes the `ur_exp_command_buffer_handle_t_` type so that
the type is encoded as an enum rather than a specific type.

Three of the specific handle types require extra data, which is now
stored in another field as a std::variant.
@RossBrunton
[UR] Replace loader handles with field at start of handle data
63c18e5 
All handles from all backends are now required to implement `ddi_getter` and their first field must be a pointer to a
`ur_ddi_table_t` (which also implies that they must not have a vtable).

Instead of wrapping handles in a special wrapper type, we instead query the DDI table stored in the handle itself. This
simplifies the loader greatly.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@RossBrunton