[UR][L0 v1/v2 adapter]Handle errors of img functions #18261
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igchor
reviewed
Apr 30, 2025
| @@ -274,7 +274,15 @@ ur_result_t createUrImgFromZeImage(ze_context_handle_t hContext, | |||
| ur_exp_image_mem_native_handle_t *pImg) { | |||
| ze_image_handle_t ZeImage; | |||
| ZE2UR_CALL(zeImageCreate, (hContext, hDevice, &ZeImageDesc, &ZeImage)); | |||
| ZE2UR_CALL(zeContextMakeImageResident, (hContext, hDevice, ZeImage)); | |||
| if (ZeImage == nullptr) { | |||
There was a problem hiding this comment.
Is it actually possible for ZeImage to be nullptr if we got SUCCESS from zeImageCreate?
| try { | ||
| ZE2UR_CALL_THROWS(zeContextMakeImageResident, (hContext, hDevice, ZeImage)); | ||
| } catch (const ze_result_t &result) { | ||
| ZE2UR_CALL(zeImageDestroy, (ZeImage)); |
There was a problem hiding this comment.
Instead of manually calling zeImageDestory (which is error prone) it would be better to use v2::raii:ze_image_handle_t
igchor
reviewed
May 6, 2025
igchor
approved these changes
May 7, 2025
pbalcer
approved these changes
May 8, 2025
|
@intel/llvm-gatekeepers please merge, the issue is unrelated and tracked here: #18349 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle errors in image functions to avoid memory leaks