[SYCL] Fix build with XPTI disabled #18269
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarnex
changed the title
Signed-off-by: Sarnie, Nick <[email protected]>
|
One sec gonna add something else |
Signed-off-by: Sarnie, Nick <[email protected]>
|
@intel/unified-runtime-reviewers @intel/llvm-reviewers-runtime This is ready for review now, thanks! |
aelovikov-intel
approved these changes
Apr 30, 2025
kbenzie
approved these changes
May 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were two issues:
UR_ENABLE_TRACINGon the command line didn't work because the SYCL code calling the FetchUR CMake files didn't useCACHE, also fixed two other vars with the same problem.Also add two errors so the problem isn't discovered in a build failure.