[UR][L0] Fix pool iteration during freelist cleanup #18406
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pbalcer
reviewed
May 12, 2025
kswiecicki
force-pushed
the
l0-async-cleanup-fix-2
branch
from
a00302f to
03fbdf3
Compare
kswiecicki
force-pushed
the
l0-async-cleanup-fix-2
branch
from
03fbdf3 to
fc3b83a
Compare
pbalcer
approved these changes
May 12, 2025
|
CI fails seem to be unrelated to the current PR as they are also present eg. here: https://github.com/intel/llvm/actions/runs/14971061195/job/42054753563.
|
igchor
approved these changes
May 12, 2025
kswiecicki
force-pushed
the
l0-async-cleanup-fix-2
branch
from
fc3b83a to
6b5e4fc
Compare
The forEachPool method stops iterating if the callback function returns false. As a result, during EnqueuedPools cleanup, pools later in the chain could be skipped if ealier pools didn't require cleanup. Additionally, ensure that user-created pools associated with the given queue handle are properly cleaned up during urQueueFinish and urQueueRelease calls.
|
@intel/llvm-gatekeepers, someone merge this please. CI job fails seem to be unrelated to this PR. |
|
@kswiecicki please check the issues list a tracker for failing tests and comment with a link to the issue when requesting a merge, even if they are unrelated to your changes, thanks! The tracker for these tests is #18416 |
github-actions bot
pushed a commit
to oneapi-src/unified-runtime
that referenced
this pull request
Jun 7, 2025
This PR mirrors fixes implemented in intel/llvm#18406 to adapter L0 v1. To cleanup async pools properly, USM pool handles must be tracked. This feature enables `UR_USM_ALLOC_INFO_POOL` prop to be implemented in `urUSMGetMemAllocInfo`.
kbenzie
pushed a commit
to oneapi-src/unified-runtime
that referenced
this pull request
Jun 9, 2025
This PR mirrors fixes implemented in intel/llvm#18406 to adapter L0 v1. To cleanup async pools properly, USM pool handles must be tracked. This feature enables `UR_USM_ALLOC_INFO_POOL` prop to be implemented in `urUSMGetMemAllocInfo`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The forEachPool method stops iterating if the callback function returns false. As a result, during EnqueuedPools cleanup, pools later in the chain could be skipped if ealier pools didn't require cleanup.
Additionally, ensure that user-created pools associated with the given queue handle are properly cleaned up during urQueueFinish and urQueueRelease calls.