[SYCL][CUDA] Implemented sampled_image_cuda.cl #1972
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nyalloc
requested review from
elizabethandrews,
Fznamznon and
premanandrao
as code owners
Fznamznon
reviewed
Jun 24, 2020
| @@ -0,0 +1,15 @@ | |||
| // RUN: %clang_cc1 %s -triple nvptx64-nvidia-cuda -O0 -emit-llvm -o - | FileCheck %s | |||
There was a problem hiding this comment.
I'm not sure that CodeGenOpenCL test is a right place for such test...
There was a problem hiding this comment.
Sorry, I don't understand how you addressed @Fznamznon's question.
There was a problem hiding this comment.
Sorry, I don't understand how you addressed @Fznamznon's question.
No worries. It was only marked WIP because it wasn't passing the clang format check. I've resolved that now and removed the WIP status.
There was a problem hiding this comment.
I'm not sure that CodeGenOpenCL test is a right place for such test...
I think @Naghasan can provide some insight into this.
nyalloc
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provides a test for functionality introduced in #1945. Should be merged after #1945.