Skip to content

Conversation

@jinge90
Copy link
Contributor

@jinge90 jinge90 commented Nov 6, 2025

The 'usesAssert' seems to be used by fallback assert mechanism which has beem discarded, create this PR to trigger pre-ci to see if any problem pops up if we remove the code snippet.

@jinge90 jinge90 requested a review from a team as a code owner November 6, 2025 04:57
@jinge90 jinge90 requested a review from slawekptak November 6, 2025 04:57
@jinge90 jinge90 marked this pull request as draft November 6, 2025 04:59
@jinge90
Copy link
Contributor Author

jinge90 commented Nov 10, 2025

Hi, @steffenlarsen
Could you take a look at this PR to see whether the 'usesAssert' metadata is used by fallback assert mechanism? If so, we can remove it.
If you are OK to remove it, I will proceed with this PR to get rid of 'usesAssert' in other components(program manager, sycl-post-link, device kernel info...)

Thanks very much.

@steffenlarsen
Copy link
Contributor

Hi, @steffenlarsen Could you take a look at this PR to see whether the 'usesAssert' metadata is used by fallback assert mechanism? If so, we can remove it. If you are OK to remove it, I will proceed with this PR to get rid of 'usesAssert' in other components(program manager, sycl-post-link, device kernel info...)

Thanks very much.

@jinge90 - Thank you for testing this out! I expect it to be fine. If everything goes green, please feel free to remove the metadata. 🚀

Signed-off-by: jinge90 <[email protected]>
Signed-off-by: jinge90 <[email protected]>
@steffenlarsen
Copy link
Contributor

Signed-off-by: jinge90 <[email protected]>
@jinge90
Copy link
Contributor Author

jinge90 commented Nov 13, 2025

@jinge90 jinge90 marked this pull request as ready for review November 18, 2025 03:00
@jinge90 jinge90 requested a review from a team as a code owner November 18, 2025 03:00
@jinge90
Copy link
Contributor Author

jinge90 commented Nov 18, 2025

Hi, @steffenlarsen
Could you help review again to check is there anything I missed?
Thanks very much.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants