-
Notifications
You must be signed in to change notification settings - Fork 795
[SYCL] Clear usesAssert required by fallback assert #20571
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: sycl
Are you sure you want to change the base?
Conversation
Signed-off-by: jinge90 <[email protected]>
|
Hi, @steffenlarsen Thanks very much. |
@jinge90 - Thank you for testing this out! I expect it to be fine. If everything goes green, please feel free to remove the metadata. 🚀 |
Signed-off-by: jinge90 <[email protected]>
Signed-off-by: jinge90 <[email protected]>
Signed-off-by: jinge90 <[email protected]>
|
Could you please also remove https://github.com/intel/llvm/blob/sycl/sycl/doc/design/PropertySets.md#syclassert-used? |
Signed-off-by: jinge90 <[email protected]>
Done. |
|
Hi, @steffenlarsen |
Signed-off-by: jinge90 <[email protected]>
The 'usesAssert' seems to be used by fallback assert mechanism which has beem discarded, create this PR to trigger pre-ci to see if any problem pops up if we remove the code snippet.