[SYCL][Graph] try to opt duplicateNodes() function. #20615
+25
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhimingwang36
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
zhimingwang36
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
zhimingwang36
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
zhimingwang36
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
zhimingwang36
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
zhimingwang36
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
zhimingwang36
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
zhimingwang36
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
zhimingwang36
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
zhimingwang36
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
Contributor
KseniyaTikhomirova
left a comment
KseniyaTikhomirova
left a comment
There was a problem hiding this comment.
handler.cpp looks ok.
| MRecordingQueues.erase(RecordingQueue.weak_from_this()); | ||
| } | ||
|
|
||
| void graph_impl::endRecording() { |
Contributor
There was a problem hiding this comment.
I don't understand why is it called "endRecording". It just checks of there is a single queue and it is in-order-queue. How does it reflect the naming?
Author
There was a problem hiding this comment.
This function is to cover work to be done at the time of ending Graph recording, like current collecting attribute(s) of the Graph before MRecordingQueues is destroyed. The right time to collect some attribute(s) of the recorded Graph is endRecording time.
|
|
||
| void graph_impl::endRecording() { | ||
| if (MRecordingQueues.size() == 1) { | ||
| MIsLinearRecorded = MRecordingQueues.begin()->lock()->isInOrder(); |
Contributor
There was a problem hiding this comment.
MRecordingQueues stores weak pointers. Technically there is a chance you can get (nullptr)->isInOrder().
Author
There was a problem hiding this comment.
Yes, will add a checker here. [Addressed]
zhimingwang36
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
zhimingwang36
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
zhimingwang36
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
zhimingwang36
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
duplicateNodes() is quite hot in graph.finalize() code path.