Skip to content

[SYCL][CI] Fix ABI-compatibility testing in pre-commit #20619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: sycl
Choose a base branch
from
Open

[SYCL][CI] Fix ABI-compatibility testing in pre-commit #20619

wants to merge 1 commit into from
+29 −18

Conversation

@kswiecicki
Copy link
Contributor

@kswiecicki kswiecicki commented Nov 12, 2025 •
edited
Loading

Added UR_FORCE_FETCH_LEVEL_ZERO and corresponding
SYCL_UR_FORCE_FETCH_LEVEL_ZERO CMake options that force Level Zero
loader fetching even if a preinstalled one is found on the platform.
This fixes undefined reference errors in the ABI-compatibility testing
jobs.

@kswiecicki kswiecicki force-pushed the ur-ci-re-enable-abi-testing branch from 347af19 to 603305d Compare November 12, 2025 15:48
@kswiecicki kswiecicki force-pushed the ur-ci-re-enable-abi-testing branch 2 times, most recently from 0a377bc to 104b013 Compare November 13, 2025 10:52
@kswiecicki kswiecicki force-pushed the ur-ci-re-enable-abi-testing branch from 104b013 to 7b10632 Compare November 14, 2025 11:29
@kswiecicki
[SYCL][CI] Fix ABI-compatibility testing in pre-commit
217c57f 
Added UR_FORCE_FETCH_LEVEL_ZERO and corresponding
SYCL_UR_FORCE_FETCH_LEVEL_ZERO CMake options that force Level Zero
loader fetching even if a preinstalled one is found on the platform.
This fixes undefined reference errors in the ABI-compatibility testing
jobs.
@kswiecicki kswiecicki force-pushed the ur-ci-re-enable-abi-testing branch from 7b10632 to 217c57f Compare November 17, 2025 14:04
@kswiecicki kswiecicki changed the title [CI] Re-enable ABI-compatibility testing in pre-commit [SYCL][CI] Fix ABI-compatibility testing in pre-commit Nov 17, 2025
@kswiecicki kswiecicki marked this pull request as ready for review November 17, 2025 14:05
@kswiecicki kswiecicki requested review from a team as code owners November 17, 2025 14:05
@kswiecicki
Copy link
Contributor Author

kswiecicki commented Nov 17, 2025

This is a fix for: #20537 (comment).
I've temporarily enabled the ABI testing jobs to see if the solution works: https://github.com/intel/llvm/actions/runs/19363228088/job/55401127202.
When it's time to enable those jobs again, removing skip_run: true should be enough.

@kswiecicki
Copy link
Contributor Author

kswiecicki commented Nov 17, 2025

The question is whether we would like to fetch L0 loader on all jobs running sycl-linux-build.yml‎ or should I specialize it for the just the ABI testing jobs?

aelovikov-intel
aelovikov-intel reviewed Nov 17, 2025
View reviewed changes
unified-runtime/cmake/FetchLevelZero.cmake
Comment on lines +17 to +18
pkg_check_modules(level-zero level-zero>=1.26.0)
if(level-zero_FOUND)
Copy link
Contributor

@aelovikov-intel aelovikov-intel Nov 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know almost nothing about this, but why wasn't the version check enough?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aelovikov-intel aelovikov-intel aelovikov-intel left review comments

@sarnex sarnex sarnex approved these changes

@sergey-semenov sergey-semenov Awaiting requested review from sergey-semenov sergey-semenov is a code owner automatically assigned from intel/llvm-reviewers-runtime

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kswiecicki @sarnex @aelovikov-intel