-
Notifications
You must be signed in to change notification settings - Fork 795
[SYCL][E2E] Move AOT tests off Gen12 #20643
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
sarnex
wants to merge
2
commits into
intel:sycl
Choose a base branch
from
sarnex:gen12aot
base: sycl
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+35
−33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nick Sarnie <[email protected]>
Contributor
|
I'm not familiar with that really... Maybe @AlexeySachkov knows more? |
Signed-off-by: Nick Sarnie <[email protected]>
YuriPlyakhin
approved these changes
Nov 17, 2025
Contributor
YuriPlyakhin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but I second that @AlexeySachkov should take a look, just in case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Windows, the GPU driver split into two, one that only supports GPUs after Gen12, and only that only supports GPUs before Gen12.
So for AOT we can't compile for BMG and Gen12 using the same
oclocexecutable.Instead of having to add LIT infrastructure for two
oclocexecutables and installing two versions on all the runners, just use DG2 instead of Gen12 for AOT tests which is supported on the new driver.Please make sure this change doesn't invalidate the test, for example if there is some capability difference between Gen12 and DG2 being tested that I broke.